fix(frontend): cap sidebar banner queue#4724
Open
mmabrouk wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
dosubot
Bot
added
the
size:S
Contributor
Railway Preview Environment
|
ardaerzin
approved these changes
Jun 17, 2026
ashrafchowdury
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
A new or localStorage-cleared user could close a sidebar banner and keep seeing older changelog cards. The sidebar rendered one card at a time, but every entry in
changelog.jsonwas still in the dismissible queue, so closing one revealed the next until all six were cleared.Changes
The sidebar banner atom now caps dismissible candidates to two before dismissal filtering. The cap happens before localStorage dismissal state is applied, so older changelog entries do not backfill after the first two dismissible cards are closed. Non-dismissible banners remain eligible.
Tests / notes
pnpm lint-fixinweb.git diff --check -- web/oss/src/components/SidebarBanners/state/atoms.ts.What to QA
agenta:dismissed-banners, open Agenta with the sidebar expanded, and dismiss the sidebar banners. After two dismissible sidebar banners are closed, older changelog cards should not continue appearing.